Merged
Conversation
erikvansebille
approved these changes
Mar 9, 2026
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Looks good, especially with the test. One comment below, bt that could be picked up in another pR?
Comment on lines
+76
to
+81
| "depth_min": abs( | ||
| expedition.instruments_config.drifter_config.depth_meter | ||
| ), # [meters] | ||
| "depth_max": abs( | ||
| expedition.instruments_config.drifter_config.depth_meter | ||
| ), # [meters] |
Member
There was a problem hiding this comment.
Perhaps not for this PR, but why would there even be a min and max depth? Especially because they are the same value. Why does a drifter not have one depth?
Collaborator
Author
There was a problem hiding this comment.
Yes good point, I'll make a new issue to address this in a separate PR. Indeed API-wise the user only has an option to set one depth value for the drifters so the min and max are redundant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements variable drifter/drogue depth functionality in VirtualShip.