feat: add joinphrases module #105

TannPat · 2025-12-03T22:13:47Z

add database model and CRUD methods
add commands for adding, getting, and deleting joinphrases
add logic to send joinphrases on user join
implement conditions of minimum time and messages since last JP per user per room
add otherHandler to track messages for miscellaneous use

PartMan7

Hi there's a couple things I've left comments on

Most of the stuff is done though, thanks! Tag me if you'd like me to implement some of the comments I've mentioned

PartMan7 · 2025-12-07T07:40:13Z

src/database/joinphrases.ts

+	},
+	userId: {
+		type: String,
+		default: toId(username),


The username here is the bot's username; that's probably not the default we want to go with - ideally this should be a function that takes the given username

PartMan7 · 2025-12-07T07:42:17Z

src/ps/commands/joinphrases.ts

+	help: 'Joinphrases module!',
+	perms: ['room', 'driver'],
+	syntax: 'CMD',
+	aliases: ['joinphrase'],


aliases and name should be swapped here - the name is the full name of the command, while aliases are abbreviations for those

PartMan7 · 2025-12-07T07:42:33Z

src/ps/commands/joinphrases.ts

+	aliases: ['joinphrase'],
+	categories: ['utility'],
+	extendedAliases: {
+		addjp: ['jp', 'new'],


Could you also add ajp, djp, and ejp? Those are currently the most commonly used ones

PartMan7 · 2025-12-07T07:46:00Z

src/ps/commands/joinphrases.ts

+				const args: string[] = arg.split(',').map(s => s.trim());
+				const username = args[0];
+				const phrase = args[1];


This is broken with commas (phrases with commas will only have the first bit)

Suggested change

const args: string[] = arg.split(',').map(s => s.trim());

const username = args[0];

const phrase = args[1];

const [username, phrase] = arg.lazySplit(/\s*,\s*/, 1);

See https://github.com/PartMan7/PartBot/blob/main/src/globals/prototypes.ts#L58 for reference

PartMan7 · 2025-12-07T07:47:12Z

src/ps/commands/joinphrases.ts

+				} catch (e: unknown) {
+					message.reply(`${username} already has a joinphrase in ${message.target.title}...` as ToTranslate);
+				}


You don't need to catch explicitly - throwing an error is the preferred approach, since that automatically handles private replies and whatnot

PartMan7 · 2025-12-07T07:57:08Z

src/ps/handlers/joins.ts

+	messageCount: number; // messages since last jp
+	lastTime: number; // timestamp of last jp
+}
+const jpStateMap: Partial<Record<string, jpState>> = {};


This should be in @/cache instead of here

PartMan7 · 2025-12-07T07:57:39Z

src/ps/handlers/joins.ts

+export function otherHandler(message: PSMessage) {
+	if (message.isIntro) return;
+	if (!message.author || !message.author.userid || !message.target || message.author.id === message.parent.status.userid) return;
+	if (message.content.startsWith('|')) return;
+	const roomId = message.target.id;
+
+	for (const key in jpStateMap) {
+		if (!jpStateMap[key]) continue;
+
+		const rId = key.split('-')[1];
+		if (rId !== roomId) continue;
+
+		jpStateMap[key]!.messageCount++;
+	} // increment message count for each joinphrase in the room
+}
+


This should be in its own file; this file is about join/leave/rename events

PartMan7 · 2025-12-07T07:59:10Z

src/ps/handlers/joins.ts

+		state = { messageCount: minimumMessages, lastTime: 0 };
+		jpStateMap[key] = state;
+	}
+	const now = Date.now() / 1000;


Try to use milliseconds instead of seconds wherever possible

PartMan7 · 2025-12-07T08:00:39Z

src/ps/handlers/joins.ts

+	for (const key in jpStateMap) {
+		if (!jpStateMap[key]) continue;
+
+		const rId = key.split('-')[1];
+		if (rId !== roomId) continue;
+
+		jpStateMap[key]!.messageCount++;
+	} // increment message count for each joinphrase in the room


Performance wise this is a bit concerning; if there's a couple hundred JPs total, you're looping over every single one of them on every message

Instead, the state map should be grouped by rooms instead so you don't iterate over JPs that aren't for the room

PartMan7 · 2025-12-07T08:01:08Z

src/ps/handlers/joins.ts

-	// (Kinda creepy name for the feature, but it CAN be used in creepy ways so make sure it's regulated!)
+
+	const userId = toId(user),
+		roomId = toId(room);


Why's room been cast to roomId here?

- add database model and CRUD methods - add commands for adding, getting, and deleting joinphrases - add logic to send joinphrases on user join

- add conditions of minimum time and messages since last JP per user per room - add otherHandler to track messages for miscellaneous use

PartMan7 · 2025-12-24T11:28:54Z

Alright, this looks good now. Thanks!

PartMan7 requested changes Dec 7, 2025

View reviewed changes

TannPat and others added 3 commits December 23, 2025 01:50

feat: add joinphrases module

c00017a

- add database model and CRUD methods - add commands for adding, getting, and deleting joinphrases - add logic to send joinphrases on user join

add minimum message and time conditions to send JP

cf7dd6b

- add conditions of minimum time and messages since last JP per user per room - add otherHandler to track messages for miscellaneous use

refactor: Assorted bugs and comments

9b10ad0

PartMan7 force-pushed the add-joinphrases branch from ff79d8e to 9b10ad0 Compare December 22, 2025 20:21

PartMan7 added 3 commits December 23, 2025 01:54

chore: Fix JP aliases

7489367

chore: Add JP feature checks

08603bd

chore: Fix JP database queries and cache sync

ba0c7ee

PartMan7 linked an issue Dec 24, 2025 that may be closed by this pull request

feat: Joinphrases #29

Closed

PartMan7 merged commit ad1516f into PartMan7:main Dec 24, 2025
4 checks passed

feat: add joinphrases module #105

feat: add joinphrases module #105

Uh oh!

Conversation

TannPat commented Dec 3, 2025

Uh oh!

PartMan7 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PartMan7 commented Dec 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants