Skip to content

Settings import, editor tabs, Windows git fixes#20

Open
GlamgarOnDiscord wants to merge 5 commits into
Paseru:mainfrom
GlamgarOnDiscord:feat/settings-import-editor-tabs-windows-fixes
Open

Settings import, editor tabs, Windows git fixes#20
GlamgarOnDiscord wants to merge 5 commits into
Paseru:mainfrom
GlamgarOnDiscord:feat/settings-import-editor-tabs-windows-fixes

Conversation

@GlamgarOnDiscord
Copy link
Copy Markdown

@GlamgarOnDiscord GlamgarOnDiscord commented May 31, 2026

Context

Several UX and Windows-specific issues in Sinew settings, editor tabs, git integration, and the chat composer. This PR groups related fixes without touching PR #11 (editor tab context menu).

Windows / platform

Git panel console leak — On Windows, spawning git and gh without CREATE_NO_WINDOW opened a new console window per subprocess; heavy git panel use stacked hundreds of windows. All subprocess launches now use the no-window flag, with cached binary paths via OnceLock.

Path normalization — Long paths and \\?\ prefixes broke Explorer reveal and shell commands. path_for_shell / display_path_string strip the prefix before UI display and explorer /select.

Explorer reveal — Reveal used exit-code checks that failed even when Explorer opened correctly; switched to fire-and-forget .spawn() on Windows.

Settings — skills & sub-agents

Backend import

  • Skills: import_skills_from_provider copies from Claude (~/.claude/skills, project .claude/skills) and Codex (~/.codex/skills, project paths) into {workspace}/.agents/skills, skipping the workspace target as a Codex source to avoid loops.
  • Sub-agents: import_sub_agents_from_provider reads Claude .md agents from ~/.claude/agents and {workspace}/.claude/agents, parses YAML frontmatter, maps model aliases (opus/sonnet/haiku), persists via existing settings store. SubAgentConfig gains source / sourcePath for traceability.

UI (Settings pane)

  • Import pickers with provider icons (Anthropic / OpenAI), green status tones, search/filter lists, enable toggles, markdown preview for sub-agents.
  • “Reveal in Explorer” on skill/sub-agent paths.
  • Container queries on settings-body: stacks below 680px, doc/list split below 520px, icon-only actions below 400px — usable with chat pane open.

Editor tabs

HTML5 drag-and-drop is unreliable in WebView2. Reorder uses pointer events with a 6px movement threshold before drag starts; click-to-activate runs on pointerup when the threshold was not exceeded (fixes tabs that only worked after drag). Shared helpers in src/lib/editorTabs.ts.

Chat composer

Textarea auto-grows with content (multiline paste/wrap) instead of a fixed height cap.

Commits (5)

  1. fix(windows): hide git subprocess consoles and normalize paths for reveal
  2. feat(settings): import skills and Claude sub-agents into workspace
  3. feat(settings): import UI, status tones, and responsive skills/sub-agents panes
  4. fix(editor): pointer tab reorder without breaking click-to-activate
  5. feat(chat): auto-grow composer height with content

Test plan

  • Windows / Git — Open Git panel, refresh/status/diff several times: no new cmd/git console windows.
  • Reveal — Skills or sub-agent with a long path: “Reveal in Explorer” opens the correct file (no false error toast).
  • Skills import — Import from Claude and Codex; files land under .agents/skills; duplicates handled sensibly; Codex does not re-import from workspace target.
  • Sub-agents import — Import from Claude; list shows name/description; preview renders markdown; enable/disable persists after restart.
  • Settings layout — Narrow settings column and with chat open: import buttons stack, list + detail remain usable.
  • Editor tabs — Single click switches tab; drag after small movement reorders; cursor pointer vs grabbing correct.
  • Composer — Paste 10+ lines: textarea grows; send still works; no layout jump in message list.

Notes

Copilot AI review requested due to automatic review settings May 31, 2026 21:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@GlamgarOnDiscord GlamgarOnDiscord force-pushed the feat/settings-import-editor-tabs-windows-fixes branch from f37ffce to a621a3c Compare May 31, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants