Settings import, editor tabs, Windows git fixes#20
Open
GlamgarOnDiscord wants to merge 5 commits into
Open
Conversation
f37ffce to
a621a3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Several UX and Windows-specific issues in Sinew settings, editor tabs, git integration, and the chat composer. This PR groups related fixes without touching PR #11 (editor tab context menu).
Windows / platform
Git panel console leak — On Windows, spawning
gitandghwithoutCREATE_NO_WINDOWopened a new console window per subprocess; heavy git panel use stacked hundreds of windows. All subprocess launches now use the no-window flag, with cached binary paths viaOnceLock.Path normalization — Long paths and
\\?\prefixes broke Explorer reveal and shell commands.path_for_shell/display_path_stringstrip the prefix before UI display andexplorer /select.Explorer reveal — Reveal used exit-code checks that failed even when Explorer opened correctly; switched to fire-and-forget
.spawn()on Windows.Settings — skills & sub-agents
Backend import
import_skills_from_providercopies from Claude (~/.claude/skills, project.claude/skills) and Codex (~/.codex/skills, project paths) into{workspace}/.agents/skills, skipping the workspace target as a Codex source to avoid loops.import_sub_agents_from_providerreads Claude.mdagents from~/.claude/agentsand{workspace}/.claude/agents, parses YAML frontmatter, maps model aliases (opus/sonnet/haiku), persists via existing settings store.SubAgentConfiggainssource/sourcePathfor traceability.UI (Settings pane)
settings-body: stacks below 680px, doc/list split below 520px, icon-only actions below 400px — usable with chat pane open.Editor tabs
HTML5 drag-and-drop is unreliable in WebView2. Reorder uses pointer events with a 6px movement threshold before drag starts; click-to-activate runs on
pointerupwhen the threshold was not exceeded (fixes tabs that only worked after drag). Shared helpers insrc/lib/editorTabs.ts.Chat composer
Textarea auto-grows with content (multiline paste/wrap) instead of a fixed height cap.
Commits (5)
fix(windows): hide git subprocess consoles and normalize paths for revealfeat(settings): import skills and Claude sub-agents into workspacefeat(settings): import UI, status tones, and responsive skills/sub-agents panesfix(editor): pointer tab reorder without breaking click-to-activatefeat(chat): auto-grow composer height with contentTest plan
cmd/gitconsole windows..agents/skills; duplicates handled sensibly; Codex does not re-import from workspace target.pointervsgrabbingcorrect.Notes
src-tauri/gen/schemas/windows-schema.jsonadded by Tauri codegen on Windows builds.