Fix broken script loading on index and cart pages, empty about page, broken 404 CSS#233
Open
zen-ash-dev wants to merge 1 commit into
Open
Fix broken script loading on index and cart pages, empty about page, broken 404 CSS#233zen-ash-dev wants to merge 1 commit into
zen-ash-dev wants to merge 1 commit into
Conversation
…ization.js, remove duplicate main.js, fix 404.css selector, populate about.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #232
The main page and cart page were both missing cart-manager.js and sanitization.js in their script tags. main.js calls both of these on startup, so without them the whole page silently breaks - the cart, the search bar, the filter buttons, the contact form, and the newsletter signup all fail with no obvious error to the user.
I found this because I was comparing pages trying to figure out why menu.html worked but index.html didn't. Turns out menu.html and orders.html already had the full set of scripts in the right order. The other two pages just didn't.
The fixes:
To test: open index.html and check the console for errors. Add an item to the cart, use the search bar, click a filter button, submit the contact form. Then open cart.html - your items should be there and the checkout button should work. Hit the 404 page and the emoji trail should be centered and animated. Visit about.html and it should redirect.