Skip to content

SAF-804 clean up react-native-background-geolocation on android#1258

Closed
tindn wants to merge 4 commits intodevelopfrom
SAF-804-geolocation-android
Closed

SAF-804 clean up react-native-background-geolocation on android#1258
tindn wants to merge 4 commits intodevelopfrom
SAF-804-geolocation-android

Conversation

@tindn
Copy link
Copy Markdown
Collaborator

@tindn tindn commented Jul 15, 2020

Apply the postinstall updates to the forked repo.

This should be merged together with Path-Check/react-native-background-geolocation#3 and Path-Check/background-geolocation-android#2 to reduce version mismatch errors

@tindn tindn requested review from JacobJaffe and jvisenti July 15, 2020 19:20
Copy link
Copy Markdown
Contributor

@jvisenti jvisenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge the PRs in the Android submodule first. We'll then also need a PR against react-native-background-geolocation to update the submodule commit to latest. Once all 3 of those are merged we can merge this PR.

Copy link
Copy Markdown
Collaborator

@JacobJaffe JacobJaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
image

Copy link
Copy Markdown
Collaborator

@johnschoeman johnschoeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tindn
Copy link
Copy Markdown
Collaborator Author

tindn commented Jul 16, 2020

@JacobJaffe , @johnschoeman , and @jvisenti , can you also help review the 2 other related PRs? This can't be merged until those are merged.

@stale
Copy link
Copy Markdown

stale Bot commented Jul 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the wontfix This will not be worked on label Jul 21, 2020
@stale stale Bot closed this Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants