Skip to content

Move control point and Double it #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BryceTieu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move control point and Double it #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions src/lib/components/ControlPointsSection.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<script lang="ts">
import type { Line } from "../../types";
import _ from "lodash";
import { snapToGrid, showGrid, gridSize } from "../../stores";

export let line: Line;
export let lineIdx: number;
export let collapsed: boolean;
export let recordChange: () => void;
export let optimizeLine: (lineId: string, targetControlPointIndex?: number) => void;
export let optimizing: boolean = false;
export let onAddControlPoint: () => void;

$: snapToGridTitle =
$snapToGrid && $showGrid ? `Snapping to ${$gridSize} grid` : "No snapping";
Expand All @@ -19,7 +19,7 @@

<div class="flex flex-col w-full justify-start items-start mt-2">
<!-- Control Points header with toggle and add button -->
<div class="flex items-center justify-between w-full">
<div class="flex items-center gap-2 w-full">
<button
on:click={toggleCollapsed}
class="flex items-center gap-2 font-light hover:bg-neutral-100 dark:hover:bg-neutral-800/50 px-2 py-1 rounded transition-colors duration-250 text-sm"
Expand All @@ -43,6 +43,29 @@
</svg>
Control Points ({line.controlPoints.length})
</button>

<button
on:click={onAddControlPoint}
class="flex items-center gap-1 px-2 py-1 text-xs font-semibold text-green-600 hover:text-green-700 disabled:opacity-40 disabled:cursor-not-allowed"
title={line.locked ? "Path locked" : "Add Control Point"}
disabled={line.locked}
>
<svg
xmlns="http://www.w3.org/2000/svg"
fill="none"
viewBox="0 0 24 24"
stroke-width={2}
stroke="currentColor"
class="size-4"
>
<path
stroke-linecap="round"
stroke-linejoin="round"
d="M12 4.5v15m7.5-7.5h-15"
/>
</svg>
Add
</button>
</div>

<!-- Control Points list (shown when expanded) -->
Expand Down
9 changes: 4 additions & 5 deletions src/lib/components/PathLineSection.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,11 @@
</div>

<div class="flex flex-row items-center gap-1 ml-auto">
<!-- Add Point After Button -->
<button
title="Add Point After This Line"
title="Add control point after this line"
on:click={onInsertAfter}
class="text-blue-500 hover:text-blue-600"
class="text-blue-500 hover:text-blue-600 disabled:opacity-40 disabled:cursor-not-allowed"
disabled={line.locked}
>
<svg
xmlns="http://www.w3.org/2000/svg"
Expand Down Expand Up @@ -330,8 +330,7 @@
bind:line
lineIdx={idx}
bind:collapsed={collapsedControlPoints}
{optimizeLine}
optimizing={optimizing}
onAddControlPoint={onInsertAfter}
{recordChange}
/>
{/if}
Expand Down