Refactor TSCH_EXEC and SMBEXEC#1250
Merged
Merged
Conversation
NeffIsBack
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Following #1191, this PR cleans up
TSCH_EXECandSMBEXECby removing duplicate authentication parameters (username, password, hashes, share_name, etc.) and the legacy manual RPC transport setup, sinceNXCRPCConnectionnow handles credentials via the SMB connection object. Call sites insmb.pyandschtask_as.pyare updated accordingly, and unusedexecute_filelesscode is removed fromSMBEXECType of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
nxc smb <IP> -u <user> -p '<pass>' --exec-method smbexec -x whoaminxc smb <IP> -u <user> -p '<pass>' --exec-method smbexec -x whoami --no-outputnxc smb <IP> -u <user> -p '<pass>' --exec-method smbexec -X "Get-Date; hostname"nxc smb <IP> -u <user> -p '<pass>' --exec-method atexec -x whoaminxc smb <IP> -u <user> -p '<pass>' --exec-method atexec -x whoami --no-outputnxc smb <IP> -u <user> -p '<pass>' --exec-method atexec -X "hostname; whoami"nxc smb <IP> -u <user> -p '<pass>' -M schtask_as -o USER=Administrator CMD=whoaminxc smb <IP> -u <user> -p '<pass>' -M schtask_as -o USER=Administrator CMD=whoami SILENTCOMMAND=TrueScreenshots (if appropriate):
I ran several tests, and it sounds good to me :
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)