fix(generate_parameter_library_py): nested mappings double dot bug

[natrad100]

• fixes a bug with nested mapping of parameters in python (removes the double dot bug)

Minor bug where two dots appear where only a single dot should.

param_name = f"{self.prefix_}nested_param.{value_1}..{value_2}.inner_param"

now

param_name = f"{self.prefix_}nested_param.{value_1}.{value_2}.inner_param"

Let me know if you'd like me to re-write the test to align better with what you have (or remove)

[christophfroehlich]

I see the issue also in the current example_python.

But instead of writing a pytest for the exported code, what do you think of adding integration tests
#25?

[christophfroehlich]

I again had a look. I think the unit test you've added is fine.

• Can you please merge the main branch into your fork's branch? (github does not allow maintainers to change branches from an organization; you also could add me as contributor to the respective repo)
• Can you remove the "fix" in the name and comments of the test file? (after it's merged, there is no fix any more).

Thanks!

[Mat198]

@christophfroehlich , I reviewed the PR and it LGTM. It solved issue #307.

I think a test comparing the internal value from generate_parameter_library with the actual node value, using the get_parameter function, would be nice. Something like this. This ensures the issue related to #307 is properly tested.

[christophfroehlich]

I think a test comparing the internal value from generate_parameter_library with the actual node value, using the get_parameter function, would be nice. Something like this. This ensures the issue related to #307 is properly tested.

Oh this is great, do you mind polishing the file and opening a PR? Even if some test cases fails, which are fixed then here..

[Mat198]

I think a test comparing the internal value from generate_parameter_library with the actual node value, using the get_parameter function, would be nice. Something like this. This ensures the issue related to #307 is properly tested.

Oh this is great, do you mind polishing the file and opening a PR? Even if some test cases fails, which are fixed then here..

I can do that! What do you mean by "polishing the file"? Are there guidelines for the tests?