single_joint_generator_test#68
Draft
zultron wants to merge 5 commits into
Draft
Conversation
Copied from `trajectory_generation_test` and stripped down for the single joint
AndyZe
approved these changes
Nov 16, 2020
AndyZe
left a comment
AndyZe
left a comment
Contributor
There was a problem hiding this comment.
Generally looks good to me!
Contributor
|
I'd be OK with merging this (even with CI not passing) because fixing the tests is beyond the scope of this PR. |
@AndyZe suggested these changes in PR #68.
zultron
force-pushed
the
zultron/single_joint_generator_test
branch
from
bf02880 to
f4b038e
Compare
Contributor
|
@zultron any reason not to merge this? It looks good to me. |
AndyZe
approved these changes
Dec 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for the
trackjoint::SingleJointGeneratorclass.