PILOT-9638: pilotx chart 1.10.0 — bridge config + GCP Secret Manager toggle#283
Open
vadimsoltan wants to merge 2 commits intomainfrom
Open
PILOT-9638: pilotx chart 1.10.0 — bridge config + GCP Secret Manager toggle#283vadimsoltan wants to merge 2 commits intomainfrom
vadimsoltan wants to merge 2 commits intomainfrom
Conversation
…toggle Adds optional Samba bridge integration to the pilotx Helm chart, gated on appConfig.bridge.enabled. When enabled, the backend deployment receives: - PILOTX_BRIDGE_ID (from appConfig.bridge.bridgeId) - PILOTX_BRIDGE_PASSWORD_SECRET_PREFIX (from appConfig.bridge.passwordSecretPrefix) - PILOTX_BRIDGE_API_TOKEN (secretKeyRef into bridgeSecret.existingSecret) These match the variables wired in pilot-gcp-infra (PILOT-9638) and consumed by the bridge endpoints PR (PILOT-9633) plus the lifecycle service (PILOT-9632). Also adds PILOTX_GCP_SECRETMANAGER_ENABLED (always emitted, defaults to false) gating the backend's per-share password creation in Secret Manager (PILOT-9857). Should be set to true in any environment where the bridge is enabled. Validation: - appConfig.bridge.enabled=true requires bridgeSecret.existingSecret - appConfig.bridge.enabled=true requires appConfig.bridge.bridgeId Bumps chart version 1.9.0 -> 1.10.0 and re-packages docs/ index per the README contribution flow. Cross-repo dependencies for end-to-end functionality (none of these block this PR's merge, but bridge integration won't be functional until they all land): - pilotx PR #133 (PILOT-9631 persistence) - pilotx PR #134 (PILOT-9632 lifecycle) - pilotx PR #135 (PILOT-9633 bridge API) - pilotx PR #148 (PILOT-9857 secret manager) - pilot-gcp-terraform-modules PRs #27/#28/#29 + 0.2.0 tag - pilot-gcp-infra PR #112 (PILOT-9638 env wiring) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional Samba bridge integration to the
pilotxchart, gated onappConfig.bridge.enabled. When enabled, the backend deployment receives the env vars needed to expose the internal bridge endpoints and provision per-share SMB password secrets in GCP Secret Manager. Bumps chart1.9.0→1.10.1and re-packagesdocs/index per the README contribution flow.ADR021 reference
bridge_idmatches the bridge VM's Terraform module input per environmentWhat the chart now produces
When
appConfig.bridge.enabled=true:Always (regardless of bridge.enabled):
Validation
appConfig.bridge.enabled=truewithoutbridgeSecret.existingSecret→helm templatehard-fails with a clear messageappConfig.bridge.enabled=truewithoutappConfig.bridge.bridgeId→ hard-failsVerified with
helm template:false✓Per-environment values (set by chart consumers)
The K8s secret should be sourced from GCP Secret Manager (e.g. via External Secrets Operator) and reference the same value as the bridge VM's
controller_auth_secret_idTerraform module input.Test plan
helm lint pilotxpasses with default valueshelm templaterenders correctly with bridge disabled (default)helm templaterenders correctly with bridge enabled + valid confighelm templatehard-fails with bridge enabled + missing required fieldshelm packageproducespilotx-1.10.1.tgzhelm repo indexupdatesdocs/index.yamlwithout dropping other chart entries