IEBH-476: Add smtp configuration for notification service#48
Merged
vmoshynskyi merged 2 commits intomainfrom May 5, 2026
Merged
IEBH-476: Add smtp configuration for notification service#48vmoshynskyi merged 2 commits intomainfrom
vmoshynskyi merged 2 commits intomainfrom
Conversation
Member
vmoshynskyi
commented
May 5, 2026
- Add smtp configuration for notification service.
There was a problem hiding this comment.
Pull request overview
Adds Vault/ExternalSecret wiring and Helm values to supply SMTP credentials/config to the notification service, enabling authenticated SMTP usage in the dev cluster.
Changes:
- Document a new Vault KV path (
secret/notification) holdingsmtp-password. - Extend the notification app’s
ExternalSecretto syncsmtp-passwordinto the in-clusternotification-credentialsSecret. - Update dev notification Helm values to use the new SMTP relay settings and source
SMTP_PASSfrom the Secret.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/vault-secrets.md | Documents the new Vault secret entry for notification SMTP password. |
| clusters/dev/apps/notification/values.yaml | Adjusts SMTP-related env vars and wires SMTP_PASS from notification-credentials. |
| clusters/dev/apps/notification/templates/external-secret.yaml | Syncs smtp-password from Vault (secret/data/notification) into the Kubernetes Secret. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.