Skip to content

IEBH-476: Add smtp configuration for notification service#48

Merged
vmoshynskyi merged 2 commits intomainfrom
IEBH-476
May 5, 2026
Merged

IEBH-476: Add smtp configuration for notification service#48
vmoshynskyi merged 2 commits intomainfrom
IEBH-476

Conversation

@vmoshynskyi
Copy link
Copy Markdown
Member

  • Add smtp configuration for notification service.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Vault/ExternalSecret wiring and Helm values to supply SMTP credentials/config to the notification service, enabling authenticated SMTP usage in the dev cluster.

Changes:

  • Document a new Vault KV path (secret/notification) holding smtp-password.
  • Extend the notification app’s ExternalSecret to sync smtp-password into the in-cluster notification-credentials Secret.
  • Update dev notification Helm values to use the new SMTP relay settings and source SMTP_PASS from the Secret.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
docs/vault-secrets.md Documents the new Vault secret entry for notification SMTP password.
clusters/dev/apps/notification/values.yaml Adjusts SMTP-related env vars and wires SMTP_PASS from notification-credentials.
clusters/dev/apps/notification/templates/external-secret.yaml Syncs smtp-password from Vault (secret/data/notification) into the Kubernetes Secret.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread clusters/dev/apps/notification/values.yaml Outdated
Comment thread clusters/dev/apps/notification/values.yaml
@vmoshynskyi vmoshynskyi merged commit 5e41edd into main May 5, 2026
4 checks passed
@vmoshynskyi vmoshynskyi deleted the IEBH-476 branch May 5, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants