Fix/fix lyrics sheet color#2486
Open
shiqizhenyes wants to merge 8 commits into
Open
Conversation
…s page control buttons
- Refine the visual effect and usage scope of the Gaussian blur while - optimizing its overall rendering smoothness. Additionally, add the new - `PlayingEqIconV2` component, featuring a spectrum animation that dynamically synchronizes with the music rhythm.
- AudioRmsSink: Introduce exponential decay for `maxRms` to prevent the visualizer from getting stuck after loud volume spikes. - AudioRmsSink: Add support for parsing 32-bit Float PCM encoding to fix amplitude calculation in Hi-Fi mode. - PlayingEqIconV2: Remove redundant `derivedStateOf` and `remember` wrappers around high-frequency data classes to eliminate recomposition overhead and animation stutters.
# Conflicts: # app/src/main/java/com/theveloper/pixelplay/presentation/viewmodel/SettingsViewModel.kt
…uages and fix the leading icon
Restore the playing indicator color in LyricsTrackInfo back to contentColor to improve readability.
Collaborator
|
Hi, can you share a screenshot of what you changed? |
Author
Restored the playing indicator to use contentColor in the LyricsTrackInfo component, based on the updates in the feat/gaussian_blur_effect_playingEqIconV2 branch. after: 
|
Collaborator
|
Why is the visualizer cutted off on the base? And why is it transparent on the pill background?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the playing indicator color in LyricsTrackInfo back to contentColor