Skip to content

Publish feedback#58

Open
fmrico wants to merge 6 commits intorollingfrom
debug_info
Open

Publish feedback#58
fmrico wants to merge 6 commits intorollingfrom
debug_info

Conversation

@fmrico
Copy link
Contributor

@fmrico fmrico commented Mar 15, 2026

Hi,

This is related to PlanSys2/ros2_planning_system#401

Nodes publish completion information via Blackboard.

Copilot AI review requested due to automatic review settings March 15, 2026 19:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-node execution progress reporting by writing a completion float (0.0–1.0) into the BehaviorTree blackboard, enabling external consumers to observe action progress.

Changes:

  • Publish completion updates from several example ActionNodeBase ticks (counter-based progress).
  • Publish completion from Move on action feedback (progress) and on success (set to 1.0).
  • Extend Move with an on_feedback(...) override and required include updates.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
plansys2_bt_example/src/behavior_tree_nodes/Recharge.cpp Sets completion based on tick counter progression.
plansys2_bt_example/src/behavior_tree_nodes/OpenGripper.cpp Sets completion based on tick counter progression.
plansys2_bt_example/src/behavior_tree_nodes/CloseGripper.cpp Sets completion based on tick counter progression.
plansys2_bt_example/src/behavior_tree_nodes/ApproachObject.cpp Sets completion based on tick counter progression.
plansys2_bt_example/src/behavior_tree_nodes/Move.cpp Adds feedback-based progress + sets completion to 1.0 on success.
plansys2_bt_example/include/plansys2_bt_example/behavior_tree_nodes/Move.hpp Declares on_feedback(...) override for progress updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fmrico and others added 6 commits March 15, 2026 21:05
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants