Skip to content

Scor android export#57

Open
Scorbutics wants to merge 7 commits into
mainfrom
scor_android_export
Open

Scor android export#57
Scorbutics wants to merge 7 commits into
mainfrom
scor_android_export

Conversation

@Scorbutics
Copy link
Copy Markdown
Collaborator

Context: https://gitlab.com/pokemonsdk/pokemonsdk/-/merge_requests/1784

Still a draft as some part can change

@Scorbutics Scorbutics force-pushed the scor_android_export branch from 3cac6ea to 0afdd9b Compare April 17, 2026 23:38
@Scorbutics Scorbutics marked this pull request as ready for review April 17, 2026 23:38
@Scorbutics Scorbutics force-pushed the scor_android_export branch from 0afdd9b to 263ffe0 Compare April 17, 2026 23:39
Comment thread plugins/export_android.rb
# Tool checks
# ---------------------------------------------------------------------------

def check_tool(name)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def check_tool(name)
  found = if Gem.win_platform?
    system("where #{name} > NUL 2>&1")
  else
    system("which #{name} > /dev/null 2>&1")
  end or abort "Required tool not found: #{name}\nPlease install it and ensure it's in your PATH." unless found
end

This change makes the tool check compatible with Windows.
Previously, the script only used which, which is mainly available on Linux/macOS.
Now, it automatically detects the platform:

where is used on Windows
which is still used on Linux/macOS

This ensures the check works properly across all operating systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants