feat: Benchmark area fix#345
Merged
Merged
Conversation
vjaganat90
force-pushed
the
benchmark_area_fix
branch
from
3462fdc to
8223db9
Compare
vjaganat90
force-pushed
the
benchmark_area_fix
branch
from
8223db9 to
cfe91d3
Compare
vjaganat90
force-pushed
the
benchmark_area_fix
branch
from
cfe91d3 to
6a036e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the polygon_area calculation bug due to incorrect direction of traversal in the final edge. And contains a benchmark for convex area calculation to track any performance regression of this feature.
It is important to note that the exact calculation of convex hull area is made consistent with the textbook definition. All derived quantities downstream of that including Solidity aren't regularized or made consistent with conventional definition or even audited for internal consistency. So the downstream numbers may yet be incorrect or the tests maybe buggy. The derived constant changes are just calculated values plugging in values from the fixed convex hull calculation.
The scope of this PR is ONLY to fix the convex area calculation and the corresponding benchmark.