Fixed typo in file name include; make base url a config option and wifi selected option inDanilo portal#1
Open
semanticdreamer wants to merge 6 commits intoPostHog:mainfrom
Open
Fixed typo in file name include; make base url a config option and wifi selected option inDanilo portal#1semanticdreamer wants to merge 6 commits intoPostHog:mainfrom
semanticdreamer wants to merge 6 commits intoPostHog:mainfrom
Conversation
Corrects a typo in the header file include path. Ensures the correct WifiInterface header is included.
Adds the ability to configure a custom base URL for the PostHog API, e.g. data regions EU or US or self-hosted. This allows users to specify a different PostHog instance or a proxy server to be used for API requests. Validates that the base URL ends with `/api/projects/` and persists it in the configuration. The API key and base URL are now required for the system to be considered fully ready.
Improves user experience by providing a placeholder value for the base URL input field, guiding the user on the expected format.
Adds the stored Wi-Fi SSID to the device configuration for pre-selection in the captive portal UI, enhancing user experience. The password field is masked for security.
Converts form submission functions to use async/await for improved readability and error handling. Adds try/catch blocks to handle potential errors during fetch requests, displaying an error message to the user. The 'refreshNetworks' function now accepts config to preselect SSID if available.
Modifies form submission handlers to prevent default form submission, ensuring JavaScript functions handle the submission process. This change avoids unexpected page reloads and ensures proper form data handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you Danilo for the nice project idea and easily approachable ESP32 setup! 👍
Here are some initial contributions that you might want to consider, or not.
I used them to familiarize myself with the code base and project structure. Also, I had to adapt the base URL to the EU data region anyway.
Changes:
BASE_URLto portal (defaulting to US data region)SSIDto config API and make current wifi networkselectedoption