fix: attempt to fix ota by fixing task timer & github api call#64
Open
wesleynw wants to merge 3 commits intoPostHog:mainfrom
Open
fix: attempt to fix ota by fixing task timer & github api call#64wesleynw wants to merge 3 commits intoPostHog:mainfrom
wesleynw wants to merge 3 commits intoPostHog:mainfrom
Conversation
wesleynw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Left some reasoning in #63.
A few different elements here:
OtaManager.cppwithesp_task_wdt_init, which, because those calls were wrapped withESP_ERROR_CHECK, caused the kernel to panic because the watchdog timer initialization call returns an error when the timer is already initialized. I've generally only seen this panic happen when checking for updates right after boot.esp_task_wdt_config_thad no effect, the watchdog timer timeout was still it's default of 5 seconds (source), not the intended 30 seconds.No_Memoryerror on update check, which is a separate issue from the kernel panics. Using the/latestroute in the github API seems to fix this. I'm not 100% sure what caused this, but I haven't gotten that error since changing the route. My working theory is that as more releases were published, it was too much data for the json parser to handle for some reason.(sorry about big whitespace diff)