Skip to content

Build step Bug Fixes #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniloc merged 6 commits into from
Dec 15, 2025
Merged

Build step Bug Fixes #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f28be3b
fix typoe and pin version
mohaidoss Nov 30, 2025
77a0876
Merge pull request #1 from mohaidoss/0.1.3-patch
mohaidoss Nov 30, 2025
46ff93d
fix constant type
mohaidoss Nov 30, 2025
f13d906
Merge pull request #2 from mohaidoss/fix_type
mohaidoss Nov 30, 2025
867d64e
Merge branch 'main' into main
Piccirello Dec 15, 2025
ce3e208
Merge branch 'main' into main
Piccirello Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion platformio.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ lib_deps =
bblanchon/ArduinoJson @ ^6.21.0
fastled/FastLED
ESP32Async/AsyncTCP
ESP32Async/ESPAsyncWebServer
ESP32Async/ESPAsyncWebServer @ 3.8.0

extra_scripts =
pre:${PROJECT_DIR}/htmlconvert.py
Expand Down
2 changes: 1 addition & 1 deletion src/ui/ProvisioningCard.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,4 +186,4 @@ class ProvisioningCard {
// Helper methods for SystemController integration
void handleSystemStateChange(const ControllerState& newState);
String apiStateToString(ApiState state);
};
};
4 changes: 2 additions & 2 deletions src/ui/QuestionCard.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ void QuestionCard::startScrolling()
lv_coord_t cont_h = lv_obj_get_height(_cont);

/* include vertical padding */
lv_coord_t pad_top = lv_obj_get_style_pad_top (_cont, 0);
lv_coord_t pad_bottom = lv_obj_get_style_pad_bottom(_cont, 0);
lv_coord_t pad_top = lv_obj_get_style_pad_top (_cont, LV_PART_MAIN);
lv_coord_t pad_bottom = lv_obj_get_style_pad_bottom(_cont, LV_PART_MAIN);

lv_coord_t distance = label_h + pad_top + pad_bottom - cont_h;
if (distance <= 0) return; // no scrolling needed
Expand Down