Skip to content

chore: remove deprecated is_simple_flag from tests #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcelobarreto wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −50
Open

chore: remove deprecated is_simple_flag from tests #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## [Unreleased]

### Maintenance
- Removed deprecated `is_simple_flag` mentions from tests.

## 3.5.3 - 2026-02-08

1. fix: Fix Railtie middleware insertion crashing on Rails initialization — changed `insert_middleware_after` from a class method to an instance method (matching how Rails executes initializer blocks via `instance_exec`), and removed the unsupported `include?` query on `MiddlewareStackProxy` ([#97](https://github.com/PostHog/posthog-ruby/issues/97))
Expand Down
7 changes: 0 additions & 7 deletions spec/posthog/client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ module PostHog
name: '',
key: 'beta-feature',
active: true,
is_simple_flag: false,
rollout_percentage: 100
}
]
Expand Down Expand Up @@ -160,7 +159,6 @@ module PostHog
'name' => '',
'key' => 'beta-feature',
'active' => true,
'is_simple_flag' => false,
'rollout_percentage' => 100,
'filters' => {
'groups' => [
Expand Down Expand Up @@ -484,7 +482,6 @@ module PostHog
name: 'Beta Feature',
key: 'beta-feature',
active: true,
is_simple_flag: false,
rollout_percentage: 100
}
]
Expand Down Expand Up @@ -522,7 +519,6 @@ module PostHog
name: 'Beta Feature',
key: 'beta-feature',
active: true,
is_simple_flag: false,
rollout_percentage: 100
}
]
Expand Down Expand Up @@ -998,7 +994,6 @@ def run
name: '',
key: 'simple_flag',
active: true,
is_simple_flag: true,
rollout_percentage: nil,
filters: {
groups: [
Expand All @@ -1011,7 +1006,6 @@ def run
name: '',
key: 'disabled_flag',
active: false,
is_simple_flag: true,
filters: {
groups: [
{ properties: [], rollout_percentage: nil }
Expand All @@ -1023,7 +1017,6 @@ def run
name: '',
key: 'complex_flag',
active: true,
is_simple_flag: false,
rollout_percentage: nil,
filters: {
groups: [
Expand Down
5 changes: 2 additions & 3 deletions spec/posthog/feature_flag_error_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ module PostHog
'name' => 'Beta Feature',
'key' => 'beta-feature',
'active' => true,
'is_simple_flag' => true,

'rollout_percentage' => 100,
'filters' => {
'groups' => [
Expand Down Expand Up @@ -386,7 +386,7 @@ module PostHog
'name' => 'Beta Feature',
'key' => 'beta-feature',
'active' => true,
'is_simple_flag' => true,

'rollout_percentage' => 100,
'filters' => {
'groups' => [
Expand All @@ -402,7 +402,6 @@ module PostHog
'name' => 'Server Only Flag',
'key' => 'server-only-flag',
'active' => true,
'is_simple_flag' => false,
'ensure_experience_continuity' => true,
'filters' => {
'groups' => [
Expand Down
Loading