Skip to content

Remove redis_nebula#84

Open
hasitha wants to merge 1 commit intomasterfrom
remove_redis_nebula
Open

Remove redis_nebula#84
hasitha wants to merge 1 commit intomasterfrom
remove_redis_nebula

Conversation

@hasitha
Copy link
Copy Markdown

@hasitha hasitha commented Dec 5, 2025

Changes

I saw this in docker randomly, and figured we don't need it anymore.

Not sure how safe this change is, but figured I'd create the PR with this change to start and then go from there :)

Ticket

https://precisionnutrition.atlassian.net/browse/XX-123

Testing Instructions

  • TODO

Screenshots (Optional)

Related PRs (Optional)


Author Checklist

  • I have run bors try (Ember apps)

  • Author wrote tests for the changes
  • Selected a team in the Reviewers drop-down to auto-assign reviewers
  • Selected one of the reviewers as the Assignee to be the primary reviewer
  • (Optional) Explained any new third-party additions

Reviewer Checklist

For the Reviewer(s)

  • Read and understood the code change.
  • Verified the changes are tested.
  • Verified the code is feature flagged (if needed).

For the Assignee (all of the above plus...)

  • Ran the code locally or on a staging server and verified it works.
  • Approved all Percy changes (if needed)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the redis_nebula service and all associated configuration from the catalog Docker setup. The removal is complete and thorough, eliminating both the Docker Compose service definition and the Nginx proxy configuration that routed traffic to it.

Key Changes:

  • Removed redis_nebula Docker service and volume from docker-compose.yml
  • Removed Nginx upstream and location block for nebula proxy routing

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
catalog/docker-compose.yml Removed redis_nebula volume declaration and service definition (redis-stack-server:6.2.6-v7 on port 6767)
catalog/docker/nginx-minimal.conf Removed nebula upstream definition and /nebula location block with proxy configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@jonhunt-pn jonhunt-pn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is fine, I don't think anyone is using this redis instance for anything

@hasitha
Copy link
Copy Markdown
Author

hasitha commented Dec 5, 2025

@jonhunt-pn Nice.

The test failures are very puzzling though. I don't think I introduced them? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants