Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the redis_nebula service and all associated configuration from the catalog Docker setup. The removal is complete and thorough, eliminating both the Docker Compose service definition and the Nginx proxy configuration that routed traffic to it.
Key Changes:
- Removed
redis_nebulaDocker service and volume from docker-compose.yml - Removed Nginx upstream and location block for nebula proxy routing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| catalog/docker-compose.yml | Removed redis_nebula volume declaration and service definition (redis-stack-server:6.2.6-v7 on port 6767) |
| catalog/docker/nginx-minimal.conf | Removed nebula upstream definition and /nebula location block with proxy configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jonhunt-pn
approved these changes
Dec 5, 2025
Contributor
jonhunt-pn
left a comment
There was a problem hiding this comment.
yeah this is fine, I don't think anyone is using this redis instance for anything
Author
|
@jonhunt-pn Nice. The test failures are very puzzling though. I don't think I introduced them? 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I saw this in docker randomly, and figured we don't need it anymore.
Not sure how safe this change is, but figured I'd create the PR with this change to start and then go from there :)
Ticket
https://precisionnutrition.atlassian.net/browse/XX-123
Testing Instructions
Screenshots (Optional)
Related PRs (Optional)
Author Checklist
bors try(Ember apps)Reviewer Checklist
For the Reviewer(s)
For the Assignee (all of the above plus...)