Skip to content

Notify author in PR size job#447

Closed
szepeviktor wants to merge 3 commits into
PrinsFrank:mainfrom
szepeviktor:patch-2
Closed

Notify author in PR size job#447
szepeviktor wants to merge 3 commits into
PrinsFrank:mainfrom
szepeviktor:patch-2

Conversation

@szepeviktor

Copy link
Copy Markdown
Contributor

Added a step to comment on PR if it exceeds size limits.

@PrinsFrank No need to open CI output.

Added a step to comment on PR if it exceeds size limits.
Added comment to clarify permissions for PR size check.

@PrinsFrank PrinsFrank left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this will work? I don't think you'd have the right permissions to do so from forks, so this will probably only work for my own PRs? https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#changing-the-permissions-in-a-forked-repository

Also, won't this keep adding comments on every push as long as a PR is over the line limit if this would work?

@szepeviktor

Copy link
Copy Markdown
Contributor Author

I really don't know.

This is an inspiration for you.

@k00ni

k00ni commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

I like the idea 😆 It supports your view on the size-limit of pull reuqests.

@PrinsFrank

Copy link
Copy Markdown
Owner

@szepeviktor Thanks for the contribution, I'll close this for now as other CI jobs are also only failing and don't comment either, and I don't think this will work cleanly out of the box. Feel free to continue working on this if you'd like!

@PrinsFrank PrinsFrank closed this Jul 6, 2026
@szepeviktor szepeviktor deleted the patch-2 branch July 6, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants