fix(auth): resolve GitHub OAuth error=github redirect loop#1299
Open
Mayur-e wants to merge 1 commit into
Open
Conversation
- Add supabaseAdmin null guard in signIn callback: when Supabase env vars are missing or contain placeholder values, supabaseAdmin is null and calling .from() on it throws a TypeError that NextAuth silently converts to error=github. Now logs a warning and returns true so auth succeeds with degraded functionality instead of crashing. - Wrap Supabase upsert in try/catch: transient DB errors (table missing, network issues) no longer block authentication. Errors are logged to the server console for operator visibility. - Add AuthErrorBanner to sign-in page: reads the ?error= query param via useSearchParams() and maps NextAuth error codes to human-readable messages (github, OAuthCallback, OAuthSignin, Configuration, AccessDenied). Wrapped in Suspense boundary for Next.js 14 static generation compatibility. Clears the param from the URL after display so stale errors do not persist across page refreshes. - Fix landing page sign-in links: all CTA and nav links that previously used raw href to /api/auth/signin/github (bypassing NextAuth CSRF token validation and causing immediate error=github) now navigate to /auth/signin instead, preserving the intended UX flow. - Expand DEVELOPMENT.md troubleshooting with a dedicated error=github redirect loop checklist covering all known root causes. Fixes #<issue-number>
|
@Mayur-e is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
gssoc26
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for your first PR on DevTrack! 🎉
A maintainer will review it within 48 hours. While you wait:
- Make sure CI is passing (type-check + lint)
- Double-check the PR description is filled out and the issue is linked
- Feel free to ask questions in Discussions if you need help
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Closes #1221
After clicking "Sign in with GitHub", users were redirected back to
/auth/signin?error=githubinstead of the dashboard.Root causes found & fixed
1.
src/lib/auth.tssupabaseAdminnull guard insignIncallback — when Supabase env vars are missing, calling.from()on null threw a TypeError that NextAuth silently converted toerror=githubtry/catchso transient errors never block login2.
src/app/auth/signin/page.tsxAuthErrorBannerthat shows a human-readable error message when?error=is in the URLuseSearchParams()in<Suspense>for Next.js 14 compatibility3.
src/components/landing/LandingPage.tsxhref="/api/auth/signin/github"bypassing NextAuth CSRF — changed tohref="/auth/signin"4.
DEVELOPMENT.mderror=githubtroubleshooting checklistTesting
npm run lint— no warnings or errorsnpm run build— all 11 pages compiledScreenshots
Before — URL shows
error=githubbut no feedback given to userAfter — Clean sign-in page on fresh visit
After — Successful login reaches dashboard
Video.webm