Skip to content

fix: add timeBlocks aggregation to contributions endpoint for CommitTimeChart#1340

Open
ionfwsrijan wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
ionfwsrijan:fix/issue-1309-committimechart
Open

fix: add timeBlocks aggregation to contributions endpoint for CommitTimeChart#1340
ionfwsrijan wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
ionfwsrijan:fix/issue-1309-committimechart

Conversation

@ionfwsrijan
Copy link
Copy Markdown

@ionfwsrijan ionfwsrijan commented May 27, 2026

Description

Fixes #1309

The CommitTimeChart component reads the timeBlocks field from the /api/metrics/contributions response to display commit distribution across morning, afternoon, evening, and night. However, the backend endpoint never computed or returned this field, causing the chart to always render "No commits" for every user.

Changes

src/app/api/metrics/contributions/route.ts

  • Added TimeBlocks interface with morning, afternoon, evening, night counters
  • Added timeBlocks field to ContributionResponse
  • Computes time-of-day bins inside fetchContributionsForAccount by extracting the hour from each commit's author.date:
    • Morning (6–12): timeBlocks.morning++
    • Afternoon (12–18): timeBlocks.afternoon++
    • Evening (18–22): timeBlocks.evening++
    • Night (22–6): timeBlocks.night++
  • Returns timeBlocks alongside existing days, total, data, and commits
  • Merges timeBlocks correctly in the combined-accounts path (per-block sums)
  • Passes through timeBlocks from the GitHub result in GitLab merge
  • GitLab contributions return zeroed timeBlocks (events don't carry hour precision)

Verification

  1. Navigate to /dashboard and observe the "Commits by Time of Day" chart
  2. Before: always shows "No commits in the last N days"
  3. After: shows horizontal bar chart with commit counts for each time block, plus peak-time label
  4. Test with 7d / 30d / 90d range selector
  5. Verify combined-accounts mode correctly aggregates time blocks across all linked accounts

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

@ionfwsrijan is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:feature GSSoC type bonus: new feature labels May 27, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@ionfwsrijan
Copy link
Copy Markdown
Author

@Priyanshu-byte-coder You may review and merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:feature GSSoC type bonus: new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CommitTimeChart is completely broken — timeBlocks data never fetched from API; chart always shows "No commits"

1 participant