Fix not unique table/alias#8
Merged
markusjwetzel merged 1 commit intoProAI:masterfrom Dec 23, 2016
chriscarpenter12:master
Merged
Fix not unique table/alias#8markusjwetzel merged 1 commit intoProAI:masterfrom chriscarpenter12:master
markusjwetzel merged 1 commit intoProAI:masterfrom
chriscarpenter12:master
Conversation
Contributor
|
Thank you! :) |
Contributor
|
Could it be that your pull request broke the update functionality (see #10)? Because I am pretty sure updating had worked before. I reverted this pull request temporarily and I am willing to re-merge it when we are certain that everything works. |
Author
|
I see what you are saying, but the way it is now without using You can see that the |
danhunsaker
pushed a commit
to danhunsaker/eloquent-versioning
that referenced
this pull request
Jun 15, 2020
Only add version when saving versioned fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed I had the same issue as #4. Started looking around and noticed that Eloquent's own SoftDeletingScope uses
$builder->withoutGlobalScope($this)->to ignore inheriting of itself on the extensions. That is what I did here. Seems to be working as expected for me.