FOUR-27675 | Email Notifications, Subject By Default Is Not Configured Correctly; Quotation Marks Are Missing#8880
Open
mcraeteisha wants to merge 1 commit into
Open
FOUR-27675 | Email Notifications, Subject By Default Is Not Configured Correctly; Quotation Marks Are Missing#8880mcraeteisha wants to merge 1 commit into
mcraeteisha wants to merge 1 commit into
Conversation
|
Contributor
|
QA server K8S was successfully deployed https://ci-9158647374.engk8s.processmaker.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Issue
Ticket: FOUR-27675
The default email notification subject seeded by the modeler rendered
{{_user.firstname}}without quotation marks, causing the user's first name to appear unquoted in task email notifications. This PR wraps the token in quotes so it matches the formatting of "{{_task_name}}".Solution
ProcessMaker/Http/Controllers/Process/ModelerController.php— UpdatedgetDefaultEmailNotification()subject template fromRE: {{_user.firstname}} assigned you in "{{_task_name}}"toRE: "{{_user.firstname}}" assigned you in "{{_task_name}}".tests/Feature/Processes/ModelerTest.php— AddedtestModelerShowExposesDefaultEmailNotificationWithQuotedUserFirstNameto assert the modeler bootstrap exposes the corrected subject to the task email notification inspector.How To Test
./vendor/bin/phpunit tests/Feature/Processes/ModelerTest.phpci:deploy
Code Review Checklist