feat(FOUR-32024): review and fix the calculation of DB timing when loaded by octane#8885
Open
rodriquelca wants to merge 1 commit into
Open
feat(FOUR-32024): review and fix the calculation of DB timing when loaded by octane#8885rodriquelca wants to merge 1 commit into
rodriquelca wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Issue & Reproduction Steps
bd:dur accumulates requests because $queryTime is static and never reset. Under Octane bd:dur grows on everey call to the same end point.
Solution
Reset $queryTime at the start of each request via beginRequestTiming() in ServerTimingMiddleware.

How to Test
./vendor/bin/phpunit tests/Feature/ServerTimingMiddlewareTest.php --testdox
Related Tickets & Packages
Code Review Checklist