Skip to content

Bugfix/four 24577#1822

Merged
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-24577
Jun 3, 2025
Merged

Bugfix/four 24577#1822
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-24577

Conversation

@rodriquelca

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

The task is set to "Task Source (Default)" in the Task Destination. Submitting one thread reloads the other and redirects to the request page (see the attached video on the parallel problem)

Solution

  • improve getActiveTokens
  • add activeTokens to processUpdated model
  • add test for getActiveTokens method
suparallel.mov

How to Test

Described in the related ticket

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@rodriquelca rodriquelca requested a review from caleeli May 29, 2025 21:54
@cypress

cypress Bot commented May 29, 2025

Copy link
Copy Markdown

screen-builder    Run #1843

Run Properties:  status check passed Passed #1843  •  git commit c9a196d3ef: Bugfix/four 24577
Project screen-builder
Branch Review bugfix/FOUR-24577
Run status status check passed Passed #1843
Run duration 42m 17s
Commit git commit c9a196d3ef: Bugfix/four 24577
Committer Rodrigo Quelca
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 374
View all changes introduced in this branch ↗︎

@julceslauhub julceslauhub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@processmaker-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ryancooley ryancooley merged commit 51ccf7b into develop Jun 3, 2025
26 of 28 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-24577 branch June 3, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants