Skip to content

FOUR-24596 It is not possible delete page in screen form even when it has no relation to any page#1828

Merged
ryancooley merged 6 commits into
developfrom
bugfix/FOUR-24596-A
Jun 26, 2025
Merged

FOUR-24596 It is not possible delete page in screen form even when it has no relation to any page#1828
ryancooley merged 6 commits into
developfrom
bugfix/FOUR-24596-A

Conversation

@gproly

@gproly gproly commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

It is not possible delete page in screen form even when it has no relation to any page

Description:

Verify the deletion of a page with data

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-24596

ci:deploy

… has no relation to any page

 ## Description:
erify the deletion of a page with data

 ## Related Tickets & Packages
https://processmaker.atlassian.net/browse/FOUR-24596
@cypress

cypress Bot commented Jun 23, 2025

Copy link
Copy Markdown

screen-builder    Run #1869

Run Properties:  status check passed Passed #1869  •  git commit 00cb222ea2: FOUR-24596 It is not possible delete page in screen form even when it has no rel...
Project screen-builder
Branch Review bugfix/FOUR-24596-A
Run status status check passed Passed #1869
Run duration 09m 13s
Commit git commit 00cb222ea2: FOUR-24596 It is not possible delete page in screen form even when it has no rel...
Committer Roly Rudy Gutierrez Pinto
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 374
View all changes introduced in this branch ↗︎

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-79b6500898.engk8s.processmaker.net

Comment thread src/components/vue-form-builder.vue Outdated
@pmPaulis pmPaulis requested a review from caleeli June 23, 2025 21:27

@caleeli caleeli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-79b6500898.engk8s.processmaker.net

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-79b6500898.engk8s.processmaker.net

@pmPaulis

Copy link
Copy Markdown
Contributor

The error showed in the unit test is not related with the changes:

Execution Controller (Tests\DataSources\Feature\Api\ExecutionController)
 ✘ Execute with whitelist
   │
   │ Expected response status code [200] but received 406.
   │ Failed asserting that 406 is identical to 200.
   │
   │ The following errors occurred during the last request:
   │
   │ {
   │     "errors": [
   │         "34.83.143.83 is not a whitelisted IP"
   │     ]
   │ }
   │
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Testing/TestResponseAssert.php:45
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Testing/TestResponse.php:160
   │ /opt/packages/package-data-sources/tests/Feature/Api/ExecutionControllerTest.php:60
   │

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-79b6500898.engk8s.processmaker.net

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-79b6500898.engk8s.processmaker.net

@pmPaulis pmPaulis changed the title FOUR-24596 It is not possible delete page in screen form even when it… FOUR-24596 It is not possible delete page in screen form even when it has no relation to any page Jun 25, 2025
@processmaker-sonarqube

Copy link
Copy Markdown

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-79b6500898.engk8s.processmaker.net

@pmPaulis

Copy link
Copy Markdown
Contributor

In sync with @gproly @ana-mauricio and @henryjonathanquispe
we review the different use cases and it's working as expected in a local enviroment, but we detect that the CI generated does not have the last changes.
Regards,

@ana-mauricio

Copy link
Copy Markdown
Contributor

The following scenarios were Tested:

  1. Page 1 with one record list, Page 2 without controls, without dependencies
  2. Page 1 with one record list, Page 2 with controls, without dependencies
  3. Page 1 with one record list, Page 2 without controls, with dependencies
  4. Page 1 with one record list, Page 2 with controls, with dependencies
  5. Page 1 with one record list, Page 2 with record list

Change in the order of the record list

  1. Page 1 without controls, Page 2 with one record list, without dependencies

  2. Page 1 with controls, Page 2 with one record list, without dependencies

  3. Page 1 without controls, Page 2 with one record list, with dependencies

  4. Page 1 with controls, Page 2 with one record list, with dependencies

  5. Page 1 with one record list, Page 2 with one record list

  6. More than one Page with different record lists, without dependencies

  7. More than one page with different record lists, with dependencies

  8. More than one page with different record lists, without dependencies, with a nested screen

  9. More than one page with different record lists, with dependencies, with a nested screen

@ryancooley ryancooley merged commit 1fa8a51 into develop Jun 26, 2025
27 of 29 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-24596-A branch June 26, 2025 12:05
pmPaulis pushed a commit that referenced this pull request Jul 8, 2025
FOUR-24596 It is not possible delete page in screen form even when it has no relation to any page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants