Skip to content

task/FOUR-25270-fix: Fixing mustache syntax variables in values with spaces#1834

Merged
nolanpro merged 2 commits into
developfrom
task/FOUR-25270-fix
Jul 21, 2025
Merged

task/FOUR-25270-fix: Fixing mustache syntax variables in values with spaces#1834
nolanpro merged 2 commits into
developfrom
task/FOUR-25270-fix

Conversation

@CarliPinell

@CarliPinell CarliPinell commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

Expected behavior: Mustache syntax must work with variables values with spaces

Actual behavior: Mustache syntax only takes first string before spaces from string value in mustache syntax

Solution

  • Filters were added to resolve mustache syntax notation in Record List control with Collections data source

How to Test

  1. Go to server https://develop-qa.processmaker.net/ or any PM4 environment
  2. Create a form screen
  3. Add a line input
    • Change the variable name to other (e.g. option)
  4. Add a record list
    • Select collection option in the Source of Record List field
    • Select any collection in the Collection Name field (e.g. Country Airports B1
      country_airports_b1.json
      )
    • Add a value like data.airportName = "Sharm El Sheikh" in the pmql field
    • Select Single field of record option in the Data Selection field
    • Select id option in the Column field
    • Display all columns in the columns accordion.
  5. Press Preview button
    • The record list is displayed according to condition data.airportName= "Sharm El Sheikh"
  6. Change the value data.airportName= "Sharm El Sheikh" to data.airportName = "{{option}}" in the pmql field
  7. Press Preview button
  8. Write "Sharm El Sheikh" in the line input

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@CarliPinell CarliPinell requested review from fagubla and pmPaulis July 15, 2025 13:31
@cypress

cypress Bot commented Jul 15, 2025

Copy link
Copy Markdown

screen-builder    Run #1900

Run Properties:  status check passed Passed #1900  •  git commit 047e66ec1f: task/FOUR-25270-fix: Fixing mustache syntax variables in values with spaces
Project screen-builder
Branch Review task/FOUR-25270-fix
Run status status check passed Passed #1900
Run duration 09m 03s
Commit git commit 047e66ec1f: task/FOUR-25270-fix: Fixing mustache syntax variables in values with spaces
Committer CarliPinell
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 372
View all changes introduced in this branch ↗︎

@processmaker-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pmPaulis pmPaulis added Beta3 and removed Beta2 labels Jul 21, 2025
@nolanpro nolanpro merged commit 2c32224 into develop Jul 21, 2025
28 of 29 checks passed
@nolanpro nolanpro deleted the task/FOUR-25270-fix branch July 21, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants