FOUR-25487 POC Use Web Worker to execute a javascript handler#1842
Closed
devmiguelangel wants to merge 3 commits into
Closed
FOUR-25487 POC Use Web Worker to execute a javascript handler#1842devmiguelangel wants to merge 3 commits into
devmiguelangel wants to merge 3 commits into
Conversation
screen-builder
|
||||||||||||||||||||||||||||
| Project |
screen-builder
|
| Branch Review |
FOUR-25487
|
| Run status |
|
| Run duration | 09m 19s |
| Commit |
|
| Committer | Miguel Angel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
19
|
Skipped
|
0
|
Passing
|
374
|
| View all changes introduced in this branch ↗︎ | |
caleeli
reviewed
Jul 31, 2025
| const rawData = data[Symbol.for("__v_raw")]; | ||
|
|
||
| const worker = new Worker(); | ||
| console.log("rawData ==> ", rawData); |
Collaborator
There was a problem hiding this comment.
Please remove the debug logs
Contributor
Author
There was a problem hiding this comment.
it was removed
caleeli
reviewed
Jul 31, 2025
| }]); | ||
|
|
||
| worker.onmessage = (e) => { | ||
| console.log("Received:", e.data); |
Collaborator
There was a problem hiding this comment.
Please remove the debug logs
Contributor
Author
There was a problem hiding this comment.
it was removed
caleeli
reviewed
Jul 31, 2025
| if (e.data.error) { | ||
| console.error("Worker error:", e.data.error); | ||
| } else if (e.data.result) { | ||
| console.log("Worker result:", e.data.result); |
Collaborator
There was a problem hiding this comment.
Please remove the debug logs
Contributor
Author
There was a problem hiding this comment.
it was removed
caleeli
reviewed
Jul 31, 2025
| const func = new Function("data", fn); | ||
| // const func = new Function('data', `return (${fn})(data)`) | ||
| const result = func(data); | ||
| console.log("result ==> ", result); |
Collaborator
There was a problem hiding this comment.
Please remove the debug logs
Contributor
Author
There was a problem hiding this comment.
it was removed
|
Collaborator
|
Merged by #1844 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
CleanShot.2025-07-30.mp4
Related Tickets & Packages
FOUR-25487
Code Review Checklist