Skip to content

fix: make clippy and typos checks pass#61

Merged
tyreseluo merged 1 commit intoProject-Robius-China:mainfrom
tyreseluo:fix/ci-clippy-typos
Apr 7, 2026
Merged

fix: make clippy and typos checks pass#61
tyreseluo merged 1 commit intoProject-Robius-China:mainfrom
tyreseluo:fix/ci-clippy-typos

Conversation

@tyreseluo
Copy link
Copy Markdown

Summary

This PR fixes current CI failures in main.yml for clippy and typos.

Changes

  • Replaced clippy-reported patterns with idiomatic equivalents:
    • removed needless explicit lifetime in tr_key
    • replaced manual ASCII case folding comparisons with eq_ignore_ascii_case
    • simplified boolean logic using is_none_or
    • replaced map_or(true, ...) with is_none_or(...)
  • Updated test string literals that were flagged by typos false positives, while keeping test intent unchanged.

Validation

  • RUSTFLAGS='-D warnings' cargo clippy --workspace --all-features passed
  • typos passed

- replace clippy-reported patterns (needless lifetimes, manual ASCII ignore-case checks, nonminimal bool, unnecessary map_or)

- adjust test literals to avoid typos false positives while preserving test intent
@tyreseluo tyreseluo merged commit a70b006 into Project-Robius-China:main Apr 7, 2026
6 of 10 checks passed
@tyreseluo tyreseluo deleted the fix/ci-clippy-typos branch April 7, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant