Skip to content

enhancement(jsx): replace innerHtml with clone from template #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KaiPrince wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhancement(jsx): replace innerHtml with clone from template #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions src/jsx-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,24 +348,14 @@ export function parseJsx(moduleURL) {
applyDomDepthSubstitutions(elementTree, undefined, hasShadowRoot);

const serializedHtml = serialize(elementTree);
// we have to Shadow DOM use cases here
// 1. No shadowRoot, so we attachShadow and append the template
// 2. If there is root from the attachShadow signal, so we just need to inject innerHTML, say in an htmx
// could / should we do something else instead of .innerHTML
// https://github.com/ProjectEvergreen/wcc/issues/138
const renderHandler = hasShadowRoot
? `
const template = document.createElement('template');
template.innerHTML = \`${serializedHtml}\`;

if(!${elementRoot}) {
this.attachShadow({ mode: 'open' });
this.shadowRoot.appendChild(template.content.cloneNode(true));
} else {
this.shadowRoot.innerHTML = template.innerHTML;
}
`
: `${elementRoot}.innerHTML = \`${serializedHtml}\`;`;

const renderHandler = `
const template = document.createElement('template');
template.innerHTML = \`${serializedHtml}\`;

${elementRoot}.textContent = '';
Copy link
Copy Markdown
Member

@thescientist13 thescientist13 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From your comment i understand the benefit of this, but wasn't sure why we would need this on new / empty shadow root? Wouldn't it already be empty? 🤔

Copy link
Copy Markdown
Contributor Author

@KaiPrince KaiPrince Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct, but from what I can tell by the code flow, we never actually had a check for if this is the first render or not.

${elementRoot}.appendChild(template.content.cloneNode(true));
`;
const transformed = acorn.parse(renderHandler, {
ecmaVersion: 'latest',
sourceType: 'module',
Expand Down