Tests: migrate from karma (deprecated) to web-test-runner#210
Draft
larabr wants to merge 4 commits intoProtonMail:mainfrom
Draft
Tests: migrate from karma (deprecated) to web-test-runner#210larabr wants to merge 4 commits intoProtonMail:mainfrom
larabr wants to merge 4 commits intoProtonMail:mainfrom
Conversation
BN.js uses a legacy export mode that needs special handling. Also, using the noble-curves API improves readability, as the scalar clamping scalar clamping needs to be explicitly disabled for the proxy transformation.
larabr
force-pushed
the
tests-drop-bnjs
branch
2 times, most recently
from
ee54eae to
fa220c6
Compare
Also drop webpack, as wtr only integrates with rollup and esbuild.
Due to X25519 issues specific to the WebKit build.
To catch issues earlier. Playwright's Webkit and Chromium builds do not include beta channels but already point to pre-release branches (see e.g. https://playwright.dev/docs/browsers#chromium).
larabr
force-pushed
the
tests-drop-bnjs
branch
from
fa220c6 to
2a3a825
Compare
twiss
approved these changes
Mar 4, 2025
Collaborator
twiss
left a comment
twiss
left a comment
There was a problem hiding this comment.
In case you're planning to rebase/merge rather than squash: there's a typo/reduplicated "scalar clamping" in the first commit message. Other than that all LGTM.
larabr
force-pushed
the
main
branch
2 times, most recently
from
5496668 to
a320cfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Karma has been deprecated for some time, and the wtr playwright integration makes it easier to run e.g. specific browser versions.
Since wtr does not integrate with webpack, we also switch to esbuild and rollup for the test bundling.
Also, fix #135 .
TODO: