-
Notifications
You must be signed in to change notification settings - Fork 20
Fix crashing the SPD3303X processor when saving #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Jasper-Harvey0 The |
|
Changed to using lambda+kwarg to introduce the delay.
|
That tolerance is tighter than the datasheet spec for the instrument, so make sense to adjust it. +/- 50 mV is probably a reasonable spot to leave it |
…t e.g; `while pps.ch1.voltage() != 0:...`
…amming it e.g; `while pps.ch1.voltage() != 0:...`" This actually doesn't do anything VISA has a builtin delay set by default for all query's to 100 msec. This reverts commit 481b77a.
|
https://pyvisa.readthedocs.io/en/latest/api/resources.html#pyvisa.resources.SerialInstrument.query_binary_values |
|
Why are the tests failing here? It is testing code that has already passed testing back in September. Have the tests changed between now and then? It appears that the test environment has not installed the cmd2.ansi module. |
The command
*SAV <X>takes ~50 ms on the SPD3303X but we only wait for ~21 ms before trying to use it which causes it to crash and needs to be power cycled before it will work again.Changes;
save.*now uses the slow write function.