Draft
Conversation
4f82f37 to
bcf9a32
Compare
Contributor
Author
|
Interesting: the careful tests fail in exactly the same way as the tests fail on the opaque pyobject build. Maybe a useful hint that there's some unsafety happening somewhere... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards fixing #5786.
This is done on top of #5753 because that PR is needed to make this work.
With some help from @davidhewitt, this almost works but subclassing seems to be broken.
I suspect using
Layoutto fill inLayoutAsBaseis incorrect here:pyo3/pyo3-macros-backend/src/pyclass.rs
Line 2833 in 5e317f0
But I'm not sure how to update the macros and the macro wrappers to get that to work correctly.
@Icxolu do you happen to have any insight about what's going wrong?
TODO:
PyModuldeDefin the FFI bindings.