-
Notifications
You must be signed in to change notification settings - Fork 409
increase transmission limit in each myopic run #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
martacki
wants to merge
3
commits into
master
Choose a base branch
from
transmission_limit_myopic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−6
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be useful! But I think the setting should be integrated in the existing setting:
or
This follows how we do this elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, I was thinking the same but ultimately the change you're suggesting would create somewhat redundant code. The
base_yearautomatically uses thetransmission_limitset in the config; just the default setting ofvoptis somewhat not optimal. It would be better to havev1.05or alike. If TYNDP expansion is active probablyv1.0would be best.But this is generally true, if not optimizing in 5 year increments but 10 year increments, I'd also use
v1.1rather thanv1.05. (Otherwise the model only has 5% increase limit for 10 years)... I guess there's no perfect way to do this?Anyway if we want to overwrite it also for the
base_year, the same fragment is needed inadd_baseyear.py.Pls let me know what you think - not only for this, but also maybe an idea how to handle the default setting depending on how the
planning_horizonincrements are set?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just checked again - main requirement would be either adding a
planning_horizontoprepare_network, or adding another parameterelec:to the keys oftransmission_limit.Increasing the limit is not necessary as the new limit is now always calculated from
s_nom_opt+p_nom_optfrom the previous horizons, so keeping it atv1.05is better. We could ofc calculate it always fromp_nom, notp_nom_opt, then your suggestion makes sense (better to resolve the issue from my previous comment, worse in case the previous horizon didn't optimise transmission much , in which case there might be a bit of excessive build-out later which I guess is rather unlikely)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be left to the user. I would not automatically infer this.
I would stick with
voptas default because this is the current state. Users can just adjust.I think the solution will come with @FabianHofmann's #1838. So this PR should be merged afterwards and this is no concern anymore.
Ok, agreed. Then the limit is always relative to the volume in the previous horizon, not relative to the capacities in the base year. That is fine. The indexing by planning horizon makes sense nevertheless as build-out could be configured to increase.
Does that sound good?