Open
Conversation
Contributor
|
I think found a typo in your stubs- You define a Protocol here: https://github.com/python/typeshed/blob/main/stubs/WebOb/webob/cookies.pyi#L29-L31 class _Serializer(Protocol):
def loads(self, appstruct: Any, /) -> bytes: ...
def dumps(self, bstruct: bytes, /) -> Any: ...I think that should read: class _Serializer(Protocol):
def dumps(self, appstruct: Any, /) -> bytes: ...
def loads(self, bstruct: bytes, /) -> Any: ...It's basically just swapping the function names. Notice how the input/output are reversed of the other functions: https://github.com/python/typeshed/blob/main/stubs/WebOb/webob/cookies.pyi#L96-L104 class JSONSerializer:
def dumps(self, appstruct: Any) -> bytes: ...
def loads(self, bstruct: bytes | str) -> Any: ...
class Base64Serializer:
serializer: _Serializer
def __init__(self, serializer: _Serializer | None = None) -> None: ...
def dumps(self, appstruct: Any) -> bytes: ...
def loads(self, bstruct: bytes) -> Any: ...Note that https://github.com/Pylons/webob/blob/main/src/webob/cookies.py#L705-L706 And https://github.com/Pylons/webob/blob/main/src/webob/cookies.py#L813-L814 |
Author
|
@jvanasco Good catch. Feel free to open an issue or PR on typeshed. |
Daverball
commented
May 21, 2025
jvanasco
added a commit
to jvanasco/typeshed
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #474
My curiosity got the better of me. So this is the stubs I contributed to typeshed automatically merged into the source using
merge_pyi.Afterwards I cleaned up any mistakes and completed the type hints for the internal API. I added a couple of type tests, but we could definitely add more.
I tried to keep changes to the actual code to a bare minimum. I did however change a couple of minor things. Like remove an unnecessary check for Python 2.7
You can do with these what you want, the diff is fairly large, so it will take some time to review.