Concept: add fish shell and zellij session backend defaults#1
Draft
Pyrobrick wants to merge 5 commits into
Draft
Concept: add fish shell and zellij session backend defaults#1Pyrobrick wants to merge 5 commits into
Pyrobrick wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concept
This is a concept implementation for making the add-on more beginner-friendly and less tmux/ZSH-opinionated by introducing selectable shell and session backend options.
What changed
shelloption withfish,zsh, andbashchoices.shell: fish.zshboolean as a legacy fallback for existing configurations that do not yet defineshell.session_backendoption withzellijandtmuxchoices.session_backend: zellij./bin/shwrapper and hands off to the selected root login shell viasudo -i.Why
Fish has much better beginner ergonomics for interactive CLI use: helpful completions, autosuggestions, syntax highlighting, and generally fewer papercuts for people who only occasionally need a terminal.
Zellij is a more discoverable terminal workspace than tmux for casual Home Assistant users. It should make shared sessions and terminal panes easier to understand without expecting users to know tmux keybindings.
Notes / caveats
This is intentionally a concept PR, not a polished upstream-ready patch yet.
Things to verify before treating this as production-ready:
fishandzellijare available in the target Alpine repositories for both supported architectures.fishandzellijpackage additions should be pinned to match the current Dockerfile style.zellij attach --create homeassistant options --default-shell <shell>behaves exactly as intended in the ttyd ingress environment.shell: fish,session_backend: zellijshell: fish,session_backend: tmuxshell: zsh,session_backend: zellijshell: bash,session_backend: tmuxzshoption should eventually be deprecated in documentation or removed in a future breaking release.In short: this is the UX direction I would want to test first, not a claim that the exact implementation is already perfect.