Bugfix: gap 'behind' the logo when using white lettering#79
Open
Jirinrin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From:
To:
(oops this gif was made with the lighting from the fragment shader turned off)
At first I thought the issue with the black gap had to do with the Z position of the white plane behind the logo, but turns out it simply had a resolution of '1' which made it not flexible enough for the vertex shader to warp it, leaving some gaps at times!
So changed the point array for that quad to one for a 5x5 rectangle grid, and this fixed it.
(by the way it still gets cut off at the sides in some cases, the shader code doesn't take into account the ratio of the container properly yet)