Skip to content

Enable upstream lint workflow on all branches #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dmidem wants to merge 3 commits into
base: sync-zcash-v4.2.0-merge
Choose a base branch
from
Draft

Enable upstream lint workflow on all branches #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d9e8ab
ci: run upstream lint check on all branches
dmidem Jun 3, 2026
dcfd755
Fix cargo clippy issues
dmidem Jun 4, 2026
b9be119
Enable upstream CI workflows for non-main branches
dmidem Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/book.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Book

on:
push:
branches: [main]
paths:
- book/**
- katex-header.html
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Coverage

on:
push:
branches: [main]
paths:
- "**/*.rs"
- "**/Cargo.toml"
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/docs-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Docs Check

on:
push:
branches: [main]
paths:
- "**.md"
- "book/**"
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@ name: Lint

on:
pull_request:
# Temporarily allow CI on the QEDIT integration branch.
# TODO: Remove v4.2.0-dev before merging upstream.
branches:
- main
- v4.2.0-dev
paths:
- "**/*.rs"
- "**/Cargo.toml"
Expand All @@ -16,11 +11,6 @@ on:
- .github/workflows/lint.yml

push:
# Temporarily allow CI on the QEDIT integration branch.
# TODO: Remove v4.2.0-dev before merging upstream.
branches:
- main
- v4.2.0-dev
paths:
- "**/*.rs"
- "**/Cargo.toml"
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/test-crates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Test Crate Build

on:
pull_request:
branches: [main]
paths:
- "**/*.rs"
- "**/Cargo.toml"
Expand All @@ -12,7 +11,6 @@ on:
- .github/workflows/test-crates.yml

push:
branches: [main]
paths:
- "**/*.rs"
- "**/Cargo.toml"
Expand Down Expand Up @@ -184,7 +182,6 @@ jobs:
cargo clippy --package ${{ matrix.crate }} --all-features --all-targets -- -D warnings
cargo build --package ${{ matrix.crate }} --all-features --all-targets


test-crate-build-success:
name: test crate build success
runs-on: ubuntu-latest
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/test-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Test Docker Config

on:
pull_request:
branches: [main]
paths:
- "**/*.rs"
- "**/Cargo.toml"
Expand All @@ -14,7 +13,6 @@ on:
- .github/workflows/test-docker.yml

push:
branches: [main]
paths:
- "**/*.rs"
- "**/Cargo.toml"
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/tests-unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Unit Tests

on:
pull_request:
branches: [main]
paths:
- "**/*.rs"
- "**/Cargo.toml"
Expand All @@ -11,7 +10,6 @@ on:
- .github/workflows/tests-unit.yml

push:
branches: [main]
paths:
- "**/*.rs"
- "**/Cargo.toml"
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/zizmor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
name: GitHub Actions Security Analysis with zizmor 🌈

on:
push:
branches: [main]
pull_request:
branches: ["**"]
on: [push]

permissions: {}

Expand Down
6 changes: 3 additions & 3 deletions zebra-node-services/src/rpc_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ impl RpcRequestClient {
let params = params.as_ref();

self.client
.post(format!("http://{}", &self.rpc_address))
.post(format!("http://{}", self.rpc_address))
.body(format!(
r#"{{"jsonrpc": "2.0", "method": "{method}", "params": {params}, "id":123 }}"#
))
Expand All @@ -54,7 +54,7 @@ impl RpcRequestClient {
let params = params.as_ref();

self.client
.post(format!("http://{}", &self.rpc_address))
.post(format!("http://{}", self.rpc_address))
.body(format!(
r#"{{"jsonrpc": "2.0", "method": "{method}", "params": {params}, "id":123 }}"#
))
Expand All @@ -73,7 +73,7 @@ impl RpcRequestClient {
let params = params.as_ref();

self.client
.post(format!("http://{}", &self.rpc_address))
.post(format!("http://{}", self.rpc_address))
.body(format!(
r#"{{"jsonrpc": "2.0", "method": "{method}", "params": {params}, "id":123 }}"#
))
Expand Down
Loading