Use exact ExpectedTranscriptError in Orchard ZSA workflow block tests (#133 alternative)

[dmidem]

This is an alternative to #133.

PR #133 replaces the is_valid: bool field in OrchardWorkflowBlock with Result<(), ExpectedTranscriptError>, but keeps block 5 as Err(ExpectedTranscriptError::Any). That version checks that block 5 fails, but still does not check the exact reason.

This PR keeps the same typed expected-result direction, but also maps the expected failure for block 5 to ExpectedTranscriptError::Exact(...).

The exact check verifies that the block is rejected because it tries to issue an asset after issuance was finalized. This is closer to the original goal from issue #116.

The downside is that the checker is more complex. In particular, CommitSemanticallyVerifiedError hides its inner CommitBlockError, so the test can type-check the public wrapper but has to inspect the specific inner InvalidIssuedAsset(Issue(IssueActionPreviouslyFinalizedAssetBase)) error via Debug output.

So the trade-off is:

• Use ExpectedTranscriptError in Orchard ZSA workflow block tests #133 is simpler and avoids depending on current error formatting, but only checks that block 5 fails.
• This PR is stricter and checks the intended rejection reason, but needs a small workaround because the exact inner error is not exposed through the current public error API.

[PaulLaux]

These changes seem to be unrelated to the "[Use exact ExpectedTranscriptError in Orchard ZSA workflow block tests (#133 alternative)]" PR

[dmidem]

Agree. I had to do this to restore the CI workflow. I have now prepared a special PR to fix the CI issue (#132). We can review and merge that one first, then pull those changes into this PR. What do you think?

[PaulLaux]

I like this approch better then #133 . Consider merging https://github.com/QED-it/zebra/pull/143/changes to get rid of the debug and clean up `ci-basic.yml' from unrelated changes.

[dmidem]

I like this approch better then #133 . Consider merging https://github.com/QED-it/zebra/pull/143/changes to get rid of the debug and clean up `ci-basic.yml' from unrelated changes.

Just merged #143 (it definitely makes sense).

Do we now need to update (possibly even remove) the comment in zebra-consensus/src/orchard_zsa/tests.rs that came from #143 (as it explains the fix of my original approach and looks obsolete after the merge)? I mean this one:

// The commit-error wrapper hides its inner error, but every layer derives
// `Error::source()`, so we can walk the chain down to the public leaf
// `AssetStateError` and match the exact variant instead of its Debug output.
if matches!(
    err.downcast_ref::<AssetStateError>(),
    Some(AssetStateError::Issue(
    orchard::issuance::Error::IssueActionPreviouslyFinalizedAssetBase
    ))
) {
    return true;
}