enrich executor_expectation_values input options#170
Merged
Conversation
add option to give (obs, bases) as input for executor_expectation_values
Coverage Report for CI Build 25098794055Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+3.4%) to 93.685%Details
Uncovered Changes
Coverage Regressions3 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
dekelmeirom
force-pushed
the
obs_and_bases_input
branch
from
1fc7b9a to
da4f555
Compare
* Docstring suggestions * cleanup docstring * typo
in addition, move the function to `expectation_values.py` file and fix documentation and formating
caleb-johnson
approved these changes
Apr 27, 2026
Collaborator
caleb-johnson
left a comment
caleb-johnson
left a comment
There was a problem hiding this comment.
This LGTM, just one small suggestion on docstring
Collaborator
caleb-johnson
left a comment
caleb-johnson
left a comment
There was a problem hiding this comment.
Could we include a release note with this as well?
Just reno new basis-format or whatever ... then just fill out the Features section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add option to give (obs, bases) as input for executor_expectation_values
in addition, add tests for
measurement_bases.pyaddresses issue #163