fix(widget): show comment form after verified identity#329
Open
Magellan-gibran wants to merge 1 commit into
Open
fix(widget): show comment form after verified identity#329Magellan-gibran wants to merge 1 commit into
Magellan-gibran wants to merge 1 commit into
Conversation
|
Daniel Rüedin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show the widget comment form for users who have already been identified by a host application when
hmacRequiredis enabled.Root cause
The existing condition requires
!hmacRequiredunconditionally. That correctly hides anonymous email capture in verified-identity mode, but it also hides the editor after a signedssoTokenhas successfully identified the user.Behavior
Verification
Adds focused regression coverage for all three cases. The patch is based on v0.13.1 and applies cleanly to current
main.