Skip to content

fix(widget): show comment form after verified identity#329

Open
Magellan-gibran wants to merge 1 commit into
QuackbackIO:mainfrom
spiritaigmbh:fix/verified-widget-comments
Open

fix(widget): show comment form after verified identity#329
Magellan-gibran wants to merge 1 commit into
QuackbackIO:mainfrom
spiritaigmbh:fix/verified-widget-comments

Conversation

@Magellan-gibran

Copy link
Copy Markdown

Summary

Show the widget comment form for users who have already been identified by a host application when hmacRequired is enabled.

Root cause

The existing condition requires !hmacRequired unconditionally. That correctly hides anonymous email capture in verified-identity mode, but it also hides the editor after a signed ssoToken has successfully identified the user.

Behavior

  • verified identity required + identified user: comment form shown
  • verified identity required + anonymous visitor: remains read-only
  • comments locked or board access denied: form remains hidden

Verification

Adds focused regression coverage for all three cases. The patch is based on v0.13.1 and applies cleanly to current main.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Daniel Rüedin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants