Skip to content

Let TimeHelper instance could be treated as Series. This fixed #156 #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcaoyuan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Let TimeHelper instance could be treated as Series. This fixed #156 #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Series.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export class Series {
constructor(public data: any[], public offset: number = 0) {}
constructor(public data: any[], public offset: number = 0) { }

public get(index: number): any {
const realIndex = this.data.length - 1 - (this.offset + index);
Expand Down Expand Up @@ -27,6 +27,7 @@ export class Series {
static from(source: any): Series {
if (source instanceof Series) return source;
if (Array.isArray(source)) return new Series(source);
if (typeof source === 'object' && '__value' in source && source.__value instanceof Series) return source.__value;
return new Series([source]); // Treat scalar as single-element array? Or handle differently?
// Ideally, scalar should be treated as a series where get(0) returns the value, and get(>0) might be undefined or NaN?
// But for now, let's wrap in array.
Expand Down