Skip to content

Improve monthly review audit controls#48

Merged
Pigbibi merged 2 commits into
mainfrom
monthly-audit-2026-05-review-controls
May 10, 2026
Merged

Improve monthly review audit controls#48
Pigbibi merged 2 commits into
mainfrom
monthly-audit-2026-05-review-controls

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR tightens the monthly audit handoff for the upstream crypto snapshot repository.

  • require same-cycle shadow outputs before generating the monthly review briefing
  • avoid duplicated Claude Primary Review headings when the primary review markdown is re-rendered with a secondary review
  • align README/runbook documentation with the current AI review and monthly optimization automation model
  • tighten the Binance zero-trade completion guard copied in the shared auto-optimization helper

Validation

  • python3 -m pytest tests/test_monthly_review_briefing.py tests/test_render_monthly_ai_review.py tests/test_prepare_auto_optimization_pr.py

Refs QuantStrategyLab/AuditOrchestrator#1

@Pigbibi Pigbibi marked this pull request as ready for review May 10, 2026 00:12

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e7b65e51e8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +168 to +171
if not availability["monthly_shadow_build_summary"]:
missing_items.append("monthly_shadow_build_summary.json")
if not availability["track_summary"]:
missing_items.append("shadow_candidate_tracks/track_summary.csv")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Enforce shadow output recency before generating review package

require_shadow_outputs currently checks only whether the two shadow files exist, so a stale monthly_shadow_build_summary.json/track_summary.csv from a previous month will still pass and let main() emit a review package. In that case the run can complete with only warnings even though the docs and commit intent require same-cycle shadow evidence, which can lead to monthly reviews being generated from mismatched data. Please validate the shadow artifacts’ as_of_date against the current cycle (or fail when mismatch warnings are present) before proceeding.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit f4dfbe0 into main May 10, 2026
1 check passed
@Pigbibi Pigbibi deleted the monthly-audit-2026-05-review-controls branch May 10, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant