Skip to content

Fix Firstrade package metadata #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jun 19, 2026
Merged

Fix Firstrade package metadata #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name = "firstrade-platform"
version = "0.1.0"
description = "Experimental QuantStrategyLab platform layer for Firstrade through an unofficial API wrapper."
readme = "README.md"
requires-python = ">=3.10"
requires-python = ">=3.11"
license = { text = "MIT" }
authors = [
{ name = "QuantStrategyLab" }
Expand All @@ -20,6 +20,22 @@ dependencies = [
"requests",
]

[tool.setuptools]
py-modules = [
"decision_mapper",
"main",

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add Flask to the packaged app dependencies

With this commit main becomes part of the installable distribution, but main.py imports from flask import ... at module import time while the pyproject.toml dependencies still do not install Flask. In a fresh environment that follows the README’s pip install -e . flow or installs the wheel and then imports main/runs gunicorn main:app, the app fails immediately with ModuleNotFoundError, so the package metadata needs to declare Flask when exposing this entrypoint.

Useful? React with 👍 / 👎.

"runtime_config_support",
"strategy_loader",
"strategy_registry",
"strategy_runtime",
]

[tool.setuptools.packages.find]
include = [
"application*",
"notifications*",
]

[tool.pytest.ini_options]
pythonpath = [
".",
Expand All @@ -29,5 +45,5 @@ pythonpath = [
testpaths = ["tests"]

[tool.ruff]
target-version = "py310"
target-version = "py311"
line-length = 100