Add IBIT market signal runtime input support#113
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad36dfcf20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| strategy_runtime_config=strategy_runtime.merged_runtime_config, | ||
| strategy_profile=settings.strategy_profile, | ||
| runtime_settings=settings, | ||
| log_message=log_message, |
There was a problem hiding this comment.
In run_strategy_cycle this keyword argument is evaluated before build_market_inputs is called, but log_message is not defined in this function or module scope. Any strategy cycle that reaches market input construction will raise NameError, including profiles that do not use market signals, so scheduled/live rebalance runs stop before evaluation. Use an existing logger such as lambda message: print(message, flush=True) or add a log_message parameter.
Useful? React with 👍 / 👎.
…nal-runtime # Conflicts: # pyproject.toml # requirements.txt
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 708cbfa9a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
| from quant_platform_kit.strategy_contracts import build_strategy_evaluation_inputs | ||
| from runtime_config_support import PlatformRuntimeSettings, load_platform_runtime_settings | ||
| from market_signal_runtime import resolve_external_market_signal_inputs |
There was a problem hiding this comment.
When this project is installed from its pyproject.toml rather than run directly from a source checkout, this new import cannot resolve because [tool.setuptools].py-modules still omits the new top-level market_signal_runtime.py. Any packaged/buildpack-style deployment or downstream pip install . consumer that imports application.rebalance_service or strategy_runtime will fail at startup with ModuleNotFoundError; add the module to the setuptools module list or package it another way.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation