Skip to content

Wire IBIT zscore exit runtime settings#119

Merged
Pigbibi merged 2 commits into
mainfrom
codex/ibit-zscore-cash-substitute
Jun 19, 2026
Merged

Wire IBIT zscore exit runtime settings#119
Pigbibi merged 2 commits into
mainfrom
codex/ibit-zscore-cash-substitute

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Load IBIT_ZSCORE_EXIT_* runtime env settings and pass them only to ibit_smart_dca.
  • Expose the new settings in deployment env sync / strategy switch plans.
  • Pin us-equity-strategies to the commit that contains IBIT z-score exit and BOXX-funded DCA support.

Test Plan

  • Targeted runtime config and strategy runtime tests for this platform
  • Env-sync workflow test for this platform
  • Ruff check on changed runtime/test files

@Pigbibi Pigbibi force-pushed the codex/ibit-zscore-cash-substitute branch from 362e0d2 to ed08611 Compare June 19, 2026 21:26
@Pigbibi Pigbibi merged commit dfd2c3a into main Jun 19, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/ibit-zscore-cash-substitute branch June 19, 2026 21:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 362e0d22c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread requirements.txt
firstrade==0.0.39
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@46ca4ea3de8f98a58e2dd86158e7f2070d085cd1
us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@173b8abbabc6a281b4707e100d248eae99e1f9d5
us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@ced1f78827e6112292af24d32dfe0e0f009e2833

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid pulling in the global ETF snapshot migration

This pin advances through the upstream commit that changes global_etf_rotation from direct market_history/portfolio_snapshot inputs to snapshot-backed feature_snapshot artifacts. In this repo, tests/test_strategy_registry.py still asserts the Firstrade adapter for global_etf_rotation uses broker runtime inputs, and the env-sync workflow will now require FIRSTRADE_FEATURE_SNAPSHOT_PATH for that profile; existing global ETF deployments without snapshot artifacts will start failing env sync instead of running from broker market data. Please either pin to a strategy commit that contains only the IBIT changes or update the platform/test/configuration for the new snapshot-backed contract.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant