Skip to content

Keep strategy plugins out of cycle notifications #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
May 26, 2026
Merged

Keep strategy plugins out of cycle notifications #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions application/rebalance_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
required_semiconductor_rotation_history_lookback,
)
from quant_platform_kit.common.strategy_plugins import (
build_strategy_plugin_notification_lines,
build_strategy_plugin_report_payload,
load_configured_strategy_plugin_signals,
parse_strategy_plugin_mounts,
Expand Down Expand Up @@ -198,14 +197,9 @@ def attach_strategy_plugin_result(
error: str | None,
translator: Callable[..., str],
) -> dict[str, Any]:
del translator
if signals:
result.update(build_strategy_plugin_report_payload(signals))
notification_lines = build_strategy_plugin_notification_lines(
signals,
translator=translator,
)
if notification_lines:
result["strategy_plugin_lines"] = notification_lines
if error:
result["strategy_plugin_error"] = error
return result
Expand Down
1 change: 0 additions & 1 deletion notifications/telegram.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,6 @@ def render_cycle_summary(result: Mapping[str, Any], *, lang: str = "en") -> str:
lines.extend(dashboard_lines)
lines.extend(_format_timing_lines(execution, translator=translator))
lines.extend(_format_signal_lines(execution, translator=translator))
lines.extend(str(line).strip() for line in result.get("strategy_plugin_lines") or ())
lines.append(SEPARATOR)
lines.extend(target_diff_lines)
if submitted:
Expand Down
6 changes: 2 additions & 4 deletions tests/test_rebalance_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,17 +278,15 @@ def fake_dispatch(signals, **kwargs):
assert result["strategy_plugins"][0]["canonical_route"] == "true_crisis"
assert result["strategy_plugin_alert_email_sent_count"] == 1
assert result["strategy_plugin_alert_sms_sent_count"] == 1
assert result["strategy_plugin_lines"] == (
"🧩 Plugin: Crisis Watch Notice | status: true crisis | notice: defend",
)
assert "strategy_plugin_lines" not in result
assert len(observed_alerts) == 1
assert observed_alerts[0][0][0].canonical_route == "true_crisis"
assert "firstrade" in observed_alerts[0][1]["context_label"]
assert observed_alerts[0][1]["notification_settings"] is settings
assert observed_alerts[0][1]["state_settings"] is not None
assert result["strategy_plugin_alert_email_deliveries"][0]["status"] == "sent"
assert result["strategy_plugin_alert_sms_deliveries"][0]["status"] == "sent"
assert "🧩 Plugin: Crisis Watch Notice | status: true crisis | notice: defend" in messages[0]
assert "🧩 Plugin:" not in messages[0]


def test_run_strategy_cycle_strategy_plugin_load_error_is_non_blocking(monkeypatch):
Expand Down