Skip to content

[codex] Harden plugin notification handling#84

Merged
Pigbibi merged 2 commits into
mainfrom
codex/firstrade-plugin-notification-hardening
Jun 16, 2026
Merged

[codex] Harden plugin notification handling#84
Pigbibi merged 2 commits into
mainfrom
codex/firstrade-plugin-notification-hardening

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • consume shared strategy plugin notification i18n from QuantPlatformKit
  • keep local fallback labels while avoiding mixed-language route reasons
  • log Telegram transport failures by exception type only
  • update QuantPlatformKit pin to d26e8019a0d7d9f1947a0e11bf8829520db60c98

Validation

  • PYTHONPATH=/home/ubuntu/Projects/QuantPlatformKit/src:. python -m py_compile notifications/telegram.py scripts/execution_report_heartbeat.py scripts/cloud_run_runtime_guard.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9cec9f7d4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread notifications/telegram.py
}

if _merge_strategy_plugin_i18n is not None:
I18N = _merge_strategy_plugin_i18n(I18N)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve local strategy-plugin labels when merging

When the new QuantPlatformKit pin is installed, _merge_strategy_plugin_i18n is present and its default merge policy lets the shared strings overwrite existing entries. Calling it without shared_wins=False means this module’s local strategy-plugin labels are no longer authoritative in production, so local formatting/wording such as the existing Telegram strategy_plugin_line output is replaced instead of only filling missing keys. If the local labels are intended to remain the fallback/override set, merge with local values winning.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 57f4874 into main Jun 16, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/firstrade-plugin-notification-hardening branch June 16, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant